Skip to content

Conversation

@mykaul
Copy link

@mykaul mykaul commented Aug 8, 2025

Fixes: #515

NOT tested.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@mykaul mykaul requested a review from Copilot August 8, 2025 16:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds optional compression dependencies (Snappy and LZ4) to the Python driver's pyproject.toml configuration. This allows users to optionally install compression libraries for enhanced functionality.

  • Adds a new compression optional dependency group containing lz4 and snappy packages

@mykaul
Copy link
Author

mykaul commented Aug 10, 2025

CI failure is #420

@dkropachev
Copy link
Collaborator

NOT tested.

I have tested both, snappy works with scylla, lz4 - i just checked it is picked up and imported properly.

@dkropachev dkropachev merged commit 84c854b into scylladb:master Aug 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specify snappy and LZ4 dependencies - right now they are totally absent from pyproject.toml, which makes them hard to discover.

2 participants